feat(harness): expose native Pi runtime - #3391
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
1b1dd43 to
a4f25c4
Compare
608c021 to
cd593d5
Compare
0e925bf to
3c236f3
Compare
![veria-ai[bot]](https://avatars.githubusercontent.com/in/1723776?s=60&v=4){kind=small}
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 2 · PR risk: 0/10 |
3c236f3 to
7388b0d
Compare
7388b0d to
1e4cd6d
Compare
| const child = spawn( | ||
| process.execPath, | ||
| [this.secureOptions.cliPath ?? "dist/cli.js", ...args], | ||
| { | ||
| cwd: this.secureOptions.cwd, | ||
| env: safePiEnvironment(process.env), | ||
| stdio: ["pipe", "pipe", "pipe", "pipe"], | ||
| }, | ||
| ); |
There was a problem hiding this comment.
would we need ELECTRON_RUN_AS_NODE=1 here?
Merge activity
|
2 participants
This cleans up the entry points towards the harness, which were getting quite muddled
It also introduces a way to spawn
piin RPC mode in@posthog/agentviarpc-host.ts, and a way to interact with the RPC host in a typed manner viarpc-client.ts